Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous improvements to the classification reference scripts #894

Merged
merged 2 commits into from
May 8, 2019

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented May 8, 2019

Summary of main changes:

  • add option to cache the datasets
    • note that the transforms are cached as well, and do not take part of the hash, so if you change the transforms, you need to either delete the previous cache or not use it
  • sync bn is optional and off by default
  • distributed initialization follows a better (but still a bit ad-hoc) ordering

@codecov-io
Copy link

codecov-io commented May 8, 2019

Codecov Report

Merging #894 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #894   +/-   ##
=======================================
  Coverage   56.79%   56.79%           
=======================================
  Files          43       43           
  Lines        3562     3562           
  Branches      546      546           
=======================================
  Hits         2023     2023           
  Misses       1418     1418           
  Partials      121      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ab2fe...5e02ae0. Read the comment docs.

@fmassa fmassa merged commit ae81313 into pytorch:master May 8, 2019
@fmassa fmassa deleted the classification-v2 branch May 8, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants